gpg: Signature made Fri Apr 25 08:54:52 2008 UTC using DSA key ID 715FC6D7
gpg: Good signature from "NextGen$ <nextgens@laposte.net>"
gpg: aka "NextGen$ <nextgens35@laposte.net>"
gpg: aka "Florent Daignière <florent.daigniere@laposte.net>"
* Matthew Toseland <toad@???> [2008-04-25 00:03:17]:
> On Thursday 24 April 2008 17:19, nextgens@??? wrote:
> > Author: nextgens
> > Date: 2008-04-24 16:19:07 +0000 (Thu, 24 Apr 2008)
> > New Revision: 19544
> >
> > Modified:
> > trunk/freenet/src/freenet/client/FECCodec.java
> > Log:
> > Hopefully fix #2287: Freenet uses too many fd's when starting a 2G+ insert,
> results in failure to persist
> >
> > Now we leave it up to the GC ASAP
>
> This isn't going to work. Bucket.getOutputStream() doesn't append, at least,
> that's always been my assumption. And Bucket.getInputStream() *ALWAYS* starts
> at zero.
Right, I missed the obvious here. Reverted in r19554.
> I expect this commit to seriously break things - did you test it?
>
Yes but not on big-enough splitfiles.
> It is conceivable that we'd run out of threads on a quad core system (192 fd's
> per encode/decode, 4 at once), but imho it's unlikely - if we're running out
> of fd's, most likely there's a leak, surely?
I'll try to replicate the bug locally and ask lsof what those FDs are.
