Re: [freenet-dev] [freenet-cvs] r19557 - trunk/freenet/src/f…

Top Page
Delete this message
Reply to this message
Author: Daniel Cheng
Date:  
To: Discussion of development issues
Subject: Re: [freenet-dev] [freenet-cvs] r19557 - trunk/freenet/src/freenet/store
On Sat, Apr 26, 2008 at 7:04 AM, Matthew Toseland
<toad@???> wrote:
> I'm reverting this before releasing 1144. You can put it back afterwards, but
> it needs to be rewritten a bit: FileChannel.read() is not guaranteed to
> complete the operation (unlike RandomAccessFile.readFully()). Also there are


fixed in r19567, thanks.

> a few RuntimeException's that you might want to catch explicitly.


there are only two RuntimeException i am awared of,
- IlleagalArgumentException, which is throw when position < 0 (impossible)
- BufferUnderFlowException, with stricter checking in new patch, this
is also impossible.