Re: [freenet-dev] [freenet-cvs] r19759 - trunk/freenet/src/f…

Top Page
Delete this message
Reply to this message
Author: Daniel Cheng
Date:  
To: Discussion of development issues
Subject: Re: [freenet-dev] [freenet-cvs] r19759 - trunk/freenet/src/freenet/support
On Tue, May 6, 2008 at 8:47 AM, Matthew Toseland
<toad@???> wrote:
> On Monday 05 May 2008 14:01, j16sdiz@??? wrote:
> > Author: j16sdiz
> > Date: 2008-05-05 13:01:55 +0000 (Mon, 05 May 2008)
> > New Revision: 19759
> >
> > Modified:
> > trunk/freenet/src/freenet/support/NumberedItemComparator.java
> > Log:
> > use assert
>
> Base must be odd?? Explain?
>
> Also the class should be package private if you're going to make this sort of
> assumptions...
>


I didn't make up that comment, I just moved the comment from below.
Can not understand that either, that's why I added an "assert".

> > + // REDFLAG: base must be odd, so we never get ==

[...]
> > return -1; // i2>i1
> > - // REDFLAG: base must be odd, so we never get ==